Update font-awesome.css #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blissdigital ( Matt ) Thanks for the PR, can you give me an example of an icon I should be looking at and if possible a screen shot? I can't look at this PR now, but I will try and look at it and merge it in tomorrow. Thanks again, really appreciate it 👍 Chris |
|
Hi Chris, Of course, a screenshot and an example icon would have been much more helpful! Here’s a before and after using ‘icon-fa-heading’
Cheers, |
|
I have just merged in your change and pushed it up to Our.umbraco.com 👍 Thanks again! |
|
You're welcome Chris, I've just uninstalled and reinstalled the new version and can confirm it works 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris,
Hope you're well mate, it's been a while! Just been using your package (great work) and noticed that a small number of FA Icons (the narrower ones) break the alignment of the Umbraco tree. this small CSS tweak restores the alignment, so thought I'd share with this PR. (Possibly something that should be in the Umbraco core, so that it works with any other custom icon fonts)
Cheers,
Matt